fixed search for deprecations

source/backporter/builder.d

@@ -41,8 +41,9 @@ Result build(const ref Config config, PackageRevision revision)
     {
         result.canTest = true;
     }
-    import std.string : indexOf;
-    result.hasDeprecations = buildResult.stderr.indexOf("Deprecated") >= 0;
+    import std.string : representation;
+    import std.algorithm.searching : canFind;
+    result.hasDeprecations = buildResult.stderr.canFind("Deprecated".representation);
     return result;
 }
 

source/backporter/git.d

@@ -6,15 +6,11 @@ import std.experimental.logger;
 import std.process;
 import std.stdio : File;
 
-File devnullWrite, devnullRead;
-
 static this()
 {
     import std.file : getcwd;
     import std.path : absolutePath, buildPath;
     dataDir = buildPath(getcwd, "projects").absolutePath;
-    devnullWrite = File("/dev/null", "w");
-    devnullRead = File("/dev/null", "r");
 }
 
 void cd(string dir)
@@ -38,16 +34,22 @@ ProcessResult run(string[] args...)
 
 ProcessResult run(Duration maxTime, string[] args...)
 {
-    import std.path : buildPath;
-    import std.file : readText;
-
     infof("running: %s", args);
     ProcessResult result;
-    auto start = Clock.currTime;
-    auto deadline = start + maxTime;
+
+    import std.path : buildPath;
     auto stderrPath = buildPath(procDir, ".stderr");
     auto childStderr = File(stderrPath, "w");
-    auto pid = spawnProcess(args, File("/dev/null", "r"), File("/dev/null", "w"), childStderr, env, Config.none, procDir);
+    auto start = Clock.currTime;
+    auto deadline = start + maxTime;
+    auto pid = spawnProcess(
+            args,
+            // stdin / stdout / stderr
+            File("/dev/null", "r"), File("/dev/null", "w"), childStderr,
+            env,
+            Config.none,
+            procDir);
+
     SysTime end;
     while (true)
     {
@@ -67,7 +69,8 @@ ProcessResult run(Duration maxTime, string[] args...)
         import core.thread : Thread;
         Thread.sleep(500.msecs);
     }
-    result.stderr = readText(stderrPath);
+    import std.file : read;
+    result.stderr = cast(const(ubyte)[])read(stderrPath);
     result.runningTime = end - start;
     return result;
 }
@@ -86,5 +89,6 @@ struct ProcessResult
     int status;
     Duration runningTime;
     bool timedOut;
-    string stderr;
+    //
+    const(ubyte)[] stderr;
 }